OWASP / threat-dragon

An open source threat modeling tool from OWASP
https://owasp.org/www-project-threat-dragon/
Apache License 2.0
902 stars 244 forks source link

Login Status is not visible Clearly in small screen width #869

Closed itsdheerajdp closed 7 months ago

itsdheerajdp commented 7 months ago

Describe what problem your feature request solves: When We open our the website in small screen width , the login status is not clearly visible in navbar as i shown below

Screenshot 2024-02-09 101200

Describe the solution you'd like: I can propose two type of the solution either we can have background color as $orange for the login status or we can have the login status in $orange color for small screen width which we can do by updating the media query . i shown both of the results in the below images

Screenshot 2024-02-09 101717

Screenshot 2024-02-09 101757

Additional context:

itsdheerajdp commented 7 months ago

What do you think about this @jgadsden

jgadsden commented 7 months ago

using a small screen for Threat Dragon is not a high priority - threat modeling with a restricted view is likely to be a poor experience, threat modeling being the creative experience and not about the tool this could be looked at for sure, but it may not be adopted

itsdheerajdp commented 7 months ago

using a small screen for Threat Dragon is not a high priority - threat modeling with a restricted view is likely to be a poor experience, threat modeling being the creative experience and not about the tool this could be looked at for sure, but it may not be adopted

media query is given for mobile screen width so that i think for this however if you want me to close this issue i'll do it further..? @jgadsden

jgadsden commented 7 months ago

Hello @itsdheerajdp , this is probably good to have - but if we change the login status as orange then it would not bee seen in a browser using a larger screen:

Screenshot 2024-02-12 at 08 39 59

Possibly black would work?

itsdheerajdp commented 7 months ago

@jgadsden in large screen this login status will be in same white color but in small screen we'll change it to orange color so that consistency in the application will be maintained i'll make this change using updatation in media query so the color in large screen will be unchanged making it black color will change the consistency in the application

jgadsden commented 7 months ago

OK, thanks @itsdheerajdp , appreciated and please go ahead with whichever solution you like best