OWASP / threat-dragon

An open source threat modeling tool from OWASP
https://owasp.org/www-project-threat-dragon/
Apache License 2.0
902 stars 244 forks source link

Contributors field is not saved #935

Closed kostasadriano closed 2 months ago

kostasadriano commented 6 months ago

Describe the bug: Contributors field is not saved

Expected behaviour: After adding contributors and saving the model, the relevant field should appear as filled.

Environment:

To Reproduce:

  1. Added Contributors
  2. Clicked Save
  3. Successfully saved message appeared
    1. When we close the screen and return to the main model page, we do not see the contributors. If we edit it again, the field now is empty as well.

Any additional context, screenshots, etc: Threat Dragon_contributors not saved_1 Threat Dragon_contributors not saved_2

jgadsden commented 6 months ago

Hello @kostasadriano , thanks for raising this. It is a feature of Threat Dragon that you have to click the 'Add' button to enter the contributor - this allows for a list of contributors to be built up, rather than a single text string:

Screenshot 2024-04-03 at 22 02 14
jgadsden commented 6 months ago

It may be that the documentation is not clear here, so marking this issue as Documentation for next release

kostasadriano commented 6 months ago

It was right in front of my eyes! Maybe the button is a bit far away and greyed. The most possible explanation though, is that the button appears only after you have added names, so before adding them I thought that the field worked like the owner and reviewer. Having it from the beginning would make it more clear.

jgadsden commented 6 months ago

yes, I agree @kostasadriano , it certainly can be improved - it is just finding someone with the time to do it :) we can update the documentation until it can be improved