search

OWASP / threat-dragon

An open source threat modeling tool from OWASP
https://owasp.org/www-project-threat-dragon/
Apache License 2.0
902 stars 244 forks source link

OWASP Threat Dragon - Logo in GitHub dark mode? #936

Closed pzrq closed 5 months ago

pzrq commented 6 months ago

Describe the bug:

I'm using the Bug type template, just because it was the first in the list and there's no obvious "other", but this is more of a question than a bug.

When I view the README.md threat dragon SVG logo in GitHub dark mode, it's barely perceptible. Is this intentional? Screenshot from 2024-04-04 16-55-54

Expected behaviour:

Unknown (hence it's one of those not really a bug bug reports which could be closed on this technicality).

Workaround

I can work around it by changing my Ubuntu > System Settings > Appearance > Style from Dark to Light, which was probably what was intended? Screenshot from 2024-04-04 16-58-11

Environment:

To Reproduce:

Any additional context, screenshots, etc:

jgadsden commented 6 months ago

That is a very good point @pzrq , and I agree it was not intentional to make cupcake disappear in Dark Mode If you have a solution for this then that would be great

pzrq commented 6 months ago

@jgadsden Thanks, I think one fix for cupcake, could be to replace the transparent pixels with white or light-coloured pixels.

Of course there are lots of other options too.

I tend to software engineer stuff, so if there's someone here on the project with actual design experience, they'd be the best person to ask, though I can have a go at the assets to just go transparent -> white in https://github.com/OWASP/threat-dragon/tree/main/td.vue/src/assets if that'd be appropriate too?

jgadsden commented 6 months ago

Yes, that seems a good plan @pzrq of you would like to go ahead and make a pull request?