Optimize Github actions

OWASP / wrongsecrets

Vulnerable app with examples showing how to not use secrets

https://owasp.org/www-project-wrongsecrets/

GNU Affero General Public License v3.0

1.2k stars 337 forks source link

Optimize Github actions #714

Open commjoen opened 1 year ago

commjoen commented 1 year ago

In order to become more efficient in CLI time there are a bunch of things we can simplify:

[ ] 1. create 1 clean-install with all the sskips in place materials to have the jar file
[ ] 2. Change swagger action to depend on 1
[ ] 3. Change DAST to depend on 1
[ ] 4. Change Docker container creation action to depend on1
[ ] Optimize many of the github actions to just run once instead of twice during a PR.
[ ] quickfail container test if something is wrong...

RemakingEden commented 1 year ago

Ive noticed the docker container Github action check does not immediately fail when something goes wrong. It hangs until the timeout has been exceeded. I think this will be using a lot of your Github minutes as the timeout is 6 hours.

Might be good to add that to the fix

puneeth072003 commented 1 year ago

@commjoen I'm really interested in working on this. Please give me this incredible opportunity.

commjoen commented 1 year ago

It is all yours ;-)

RemakingEden commented 1 year ago

So ive got a couple of other ideas of how to clean up the pipelines a little. @commjoen @puneeth072003 let me know if I should start another ticket or we should add to this one.

Clean up test workflow output. Right now as we are running everything through maven we get a lot of output based on the build and running. I find it can be a little tricky to figure out the debug message you are actually looking for. I either think simplified output from maven or perhaps a test report that is exported with each run.
Consistent naming conventions and a workflow file for each distinct piece e.g. a test workflow file and a security workflow file. The only problems I can forsee with this is that you can't move artifacts between each workflow file so if you want workflows to depend on each other it is tricky.

commjoen commented 1 year ago

Good to do that in this issue :-)

puneeth072003 commented 1 year ago

@RemakingEden Great suggestions!! Happy to implement those

commjoen commented 1 year ago

Will be picked up after https://github.com/OWASP/wrongsecrets-binaries/pull/35 :) .

puneeth072003 commented 12 months ago

I'll start by task 3

[x] Change DAST to depend on 1

puneeth072003 commented 10 months ago

@commjoen happy to continue with the issue