OWASP / wstg

The Web Security Testing Guide is a comprehensive Open Source guide to testing the security of web applications and web services.
https://owasp.org/www-project-web-security-testing-guide/
Creative Commons Attribution Share Alike 4.0 International
7.04k stars 1.3k forks source link

Update 10-Map_Application_Architecture.md #1063

Closed jinsonvarghese closed 1 year ago

jinsonvarghese commented 1 year ago

What did this PR accomplish?

Thank you for your contribution!

github-actions[bot] commented 1 year ago

The following mistakes were identified:

/home/runner/work/wstg/wstg/document/4-Web_Application_Security_Testing/01-Information_Gathering/10-Map_Application_Architecture.md 120:28 ✖ Incorrect usage of the term: “back end”, use “backend” instead terminology 143:115 ✖ Incorrect usage of the term: “website”, use “site” instead terminology 157:59 ✖ Incorrect usage of the term: “back end”, use “backend” instead terminology 175:39 ✖ Incorrect usage of the term: “IDS”, use “IDs” instead terminology 191:96 ✖ Incorrect usage of the term: “back end”, use “backend” instead terminology

github-actions[bot] commented 1 year ago

The following mistakes were identified:

/home/runner/work/wstg/wstg/document/4-Web_Application_Security_Testing/01-Information_Gathering/10-Map_Application_Architecture.md 175:39 ✖ Incorrect usage of the term: “IDS”, use “IDs” instead terminology

jinsonvarghese commented 1 year ago

This is an acronym.

jinsonvarghese commented 1 year ago

@kingthorin A page for Fingerprint Web Application exists, even though its merged with Fingerprint Web Application Framework.

Should this page be removed, and index adjusted accordingly? If you need me to do it, please let me know.

kingthorin commented 1 year ago

The way 08 and 09 currently are is fine. They won't be adjusted until we're ready for v5.

The IDS vs IDs thing could be fixed in the config if you're feeling ambitious, or we can just ignore it. Obviously we didn't put enough thought into that rule.

https://github.com/OWASP/wstg/blob/94ddaf98a7be91ae01e50903faa587b082e7be3d/.github/configs/.textlintrc#L126-L127

I think just removing the question mark should be sufficient, so that id's or id’s will get the IDs suggestion, but IDS should be fine.

github-actions[bot] commented 1 year ago

The following mistakes were identified:

/home/runner/work/wstg/wstg/document/4-Web_Application_Security_Testing/01-Information_Gathering/10-Map_Application_Architecture.md 175:39 ✖ Incorrect usage of the term: “IDS”, use “IDs” instead terminology

jinsonvarghese commented 1 year ago

Sure thing!

kingthorin commented 1 year ago

Please make sure you add yourself to the Editors list in one of your next PRs: https://github.com/OWASP/wstg/tree/master/document/1-Frontispiece#reviewers-or-editors

jinsonvarghese commented 1 year ago

Please make sure you add yourself to the Editors list in one of your next PRs: https://github.com/OWASP/wstg/tree/master/document/1-Frontispiece#reviewers-or-editors

Oh I am already there. "Jinson Varghese Behanan" 😄 @kingthorin

kingthorin commented 1 year ago

Perfect!