search

OWASP / wstg

The Web Security Testing Guide is a comprehensive Open Source guide to testing the security of web applications and web services.
https://owasp.org/www-project-web-security-testing-guide/
Creative Commons Attribution Share Alike 4.0 International
7.35k stars 1.33k forks source link

Invisible code parts - bright blue text on the blue background #1116

Open mbiesiad opened 11 months ago

mbiesiad commented 11 months ago

What's the issue? Text color used in combination with the background color makes it almost invisible.

How do we solve it? Use other color (than presented at the screenshots below) for these code parts - not bright blue.

Would you like to be assigned to this issue? No

Repro steps:

  1. Go to https://owasp.org/www-project-web-security-testing-guide/v41/4-Web_Application_Security_Testing/07-Input_Validation_Testing/18-Testing_for_Server_Side_Template_Injection
  2. Scroll down to see code parts (examples)

Screenshots ❌

image or image

Additional information

Please notice that current 'effect of colors' make it unuseful - better result is even if we use white text with uniformed background: image

Best wishes,

kingthorin commented 11 months ago

Unfortunately that's a failing of the OWASP Site theme. I'll look at getting this issue moved and the item addressed.

mbiesiad commented 11 months ago

Hi @kingthorin Thank you for quick reaction and message. I can see. Sounds great! ✨

kingthorin commented 11 months ago

Dose this seem workable? image image

#F0F0F0

mbiesiad commented 11 months ago

image

From my point of view, it's much better! ✔

kingthorin commented 11 months ago

Okay, I'll see if I can add some css/scss to override that for the wstg deployment(s).

kingthorin commented 11 months ago

I've tried a few things in a local environment without success. I'll ask around for other ideas.