search

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

reducing the extra spaces at top #24

Closed anantshri closed 4 years ago

anantshri commented 4 years ago

The top OWASP banner takes too much space and does look decent with half the height also. this css fix will reduce that size and will also remove the unnecessary margin to get more visible content on the front face.

Top is the proposed View and bottom is the current view.

Screenshot at 2019-11-28 15-25-36

kingthorin commented 4 years ago

I'm good with the proposed screenshot. @anantshri have you tested on mobile or responsive design mode (to see how it looks on smaller screens)?

anantshri commented 4 years ago

I have added these changes via custom CSS for everyone to see at my chapter page https://www2.owasp.org/www-chapter-bhopal/ you can see slimer header etc.

hblankenship commented 4 years ago

You realize that we had already reduced it quite a bit?

anantshri commented 4 years ago

ya i can see https://github.com/OWASP/www--site-theme/commit/f013c165683a2596e96bb3859cb651e2fee74298#diff-c23b78981f9b34f2b2975cd9be4a1e77

20px from header and 15 px from bottom margin.

I am proposing 60px from header and 30px all together from bottom margin. You have a working example can you suggest why we should keep those extra whitespaces which could be utilized for something else.

I would keep on optimizing or experimenting with my chapter page to see what more could be done. i am using it as a base for you to see alternative options. Its ultimately your call what goes in the template layout.

hblankenship commented 4 years ago

Updated header to 80px to maintain a clean look with logo. bottom margin reduced to 8, not 0