Subdirs - Githubissues

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)

9 stars 26 forks source link

Subdirs #32

Open drwetter opened 4 years ago

drwetter commented 4 years ago

.. are not working or am I missing something?

For our German Chapter we have links like https://www.owasp.org/index.php/OWASP_German_Chapter_Stammtisch_Initiative/Hamburg and https://www.owasp.org/index.php/Germany/Chapter_Meetings (cc @bkimminich).

Thx, Dirk

drwetter commented 4 years ago

Hi @hblankenship ,

this is currently a showstopper for us. Please advise.

Thanks in advance, Dirk

bkimminich commented 4 years ago

I guess I stackoverflowed the problem...

remote_theme: "owasp/www--site-theme"
plugins:
 - jekyll-include-cache-0.2.0
include:
 - 'stammtische'
 - 'stammtische/hamburg'
 - 'chapter_meetings'

Now the subdirs work to some extent. Open issues:

tabs are broken once you are in a subdirectory, because they seem to be trying to resolve relatively within the subdir
the sidenav is not inherited from the repo, only from the very top level it seems. I guess this can be fixed somehow without duplicating the nav files

drwetter commented 4 years ago

ok, thanks. One step forward.

hblankenship commented 4 years ago

Subdirs and tabs within them work without the config changes unless I recently broke something. They require an info.md file within the subdir (with col-sidebar).

drwetter commented 4 years ago

Do you have an example of such an info.md?

hblankenship commented 4 years ago

Example: https://www2.owasp.org/www-projectchapter-example/subproject/

drwetter commented 4 years ago

Looks good, Thanks. I'll give it a try and let you know

drwetter commented 4 years ago

(Kind of ) works. Thanks.

See https://www2.owasp.org/www-chapter-germany/stammtische/

Not sure though what causes the header to appear/disappear. If e.g. I add tags the tabs show up again.

And what is the deal with the subdir info. What can I modify and what not?

hblankenship commented 4 years ago

See the https://www2.owasp.org/migration page for details on the various items, especially the section on tabs. Let me know if that doesn't answer your question.

drwetter commented 4 years ago

Harold, that are the basics. But unless I overlooked something it doesn't tell me why the info.md need to contain what you suggested and when I modify things, what is going to happen. Also it doesn't mention when I readd tags again the tabs show up.

And honestly to find out this is quite tedious process with try and error.

It's enough for me today. I went through a lot of turn around cycles ...