search

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

Uglyness of spacing #35

Closed drwetter closed 4 years ago

drwetter commented 4 years ago

Hi,

as of now the result looks pretty much like a page in Markdown and not a page in HTML. This is IMO not appropriate for a modern web site. The most disturbing issue to the eyes is the spacing between headlines and subsequent text.

Screenshot_20191219_094712

The headlines have the same spacing as to the text below as to above. Worse, some times it looks like the spacing of the headline to its paragraph is bigger.

Suggestion: Provide a proper style property (CSS) which has smaller space to below and keep the space to above. At the moment there's no style for h2 or h3.

hblankenship commented 4 years ago

h2, h3, h4 all have styles....is this specific to mobile? I'll look there.

drwetter commented 4 years ago

Nope, that was taken from https://www2.owasp.org/www-project-docker-top-10/. To be precise: If I look at the debugger I see a style:

h1, h2, h3, h4, h5, h6, strong {
    font-family: 'titillium', sans-serif;
    font-weight: bold;
}

But not something which I meant.

drwetter commented 4 years ago

and there's a style for the side bar which nullifies all margins. Likely we want instead to set them?

hblankenship commented 4 years ago

In the info.md file, you can use * lists to remove spacing:

The list is shown without decoration.

drwetter commented 4 years ago

Harold,

What? please reopen.

I don't want bullet lists. As mentioned I want the headline on the sidebar (and on the main page) to have proper spacing. It has now the same distance to above as to below.

It looks rotten ugly and definitely not like we should present this to a visitor.

Thanks, Dirk