OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

Search Button Firefox Issue #49

Closed kingthorin closed 4 years ago

kingthorin commented 4 years ago

The search button is always fully or partially obscured on Firefox. In fact the first number of times I saw it I thought it was some weird orphaned letter "C". Until recently when I browsed the site in Chrome.

image

hblankenship commented 4 years ago

Any chance you are zoomed in? I am not seeing that in Firefox on my system. How about screen resolution?

-

Harold L. Blankenship

OWASP Foundation

Director of Technology and Projects

On Tue, Feb 11, 2020 at 1:14 PM kingthorin notifications@github.com wrote:

The search button is always fully or partially obscured on Firefox. In fact the first number of times I saw it I thought it was some weird orphaned letter "C". Until recently when I browsed the site in Chrome.

[image: image] https://user-images.githubusercontent.com/7570458/74270144-be71d700-4cd8-11ea-83d0-63d5565801ea.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OWASP/www--site-theme/issues/49?email_source=notifications&email_token=AIXZRIWSAIMX34Z55QTXO73RCL2K3A5CNFSM4KTGZM7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMVCREQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIXZRISORJL6TWXWN4EUGITRCL2K3ANCNFSM4KTGZM7A .

kingthorin commented 4 years ago

Zero zoom, and OS Level "Change the size of text, apps, and other items" left at 100%, res is: 1920x1080 with Firefox window maximized.

Just adjusted to 1280x1024 and it persists.

Also disabled uBlock Origin so ensure it wasn't impacting things.

hblankenship commented 4 years ago

Hrmm 1920x1080 is also my res.

Harold L. Blankenship

OWASP Foundation

Director of Technology and Projects

On Tue, Feb 11, 2020 at 1:44 PM kingthorin notifications@github.com wrote:

Zero zoom, and OS Level "Change the size of text, apps, and other items" left at 100%, res is: 1920x1080 with Firefox window maximized.

Just adjusted to 1280x1024 and it persists.

Also disabled uBlock Origin so ensure it wasn't impacting things.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OWASP/www--site-theme/issues/49?email_source=notifications&email_token=AIXZRIQUJTF6R3MADTULGZ3RCL52ZA5CNFSM4KTGZM7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELNZOZI#issuecomment-584816485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIXZRIW4ML3IYHTBTB23ZJTRCL52ZANCNFSM4KTGZM7A .

hblankenship commented 4 years ago

I merged #40, please verify the fix worked for your case?

kingthorin commented 4 years ago

Thanks, yes that seems to have done it. image

kingthorin commented 4 years ago

Well it's positioned properly if you are at the top of the screen but when you scroll it travels with you.

image

hblankenship commented 4 years ago

Try it now

kingthorin commented 4 years ago

I think you've got it, thanks!