search

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

update yaml parser to remove deprecated API #56

Closed lpmi-13 closed 4 years ago

lpmi-13 commented 4 years ago

the current site uses an old version of yaml.min.js, which calls a synchronous XMLHttpRequest, which is deprecated.

This commit updates the version of the file, which doesn't call this API.

deprecated API

hblankenship commented 4 years ago

This seems to break the yaml in jquery-3.4.1.min.js as well as the use in member.html?

lpmi-13 commented 4 years ago

Yeah, to be fair I had a bit of trouble testing out the switch locally... my jekyll knowledge isnt good enough to keep the remote template (even pointing the config to my fork of the theme) from trying to get the jquery at owasp.org/assets/js first, leading to an error in the console complaining about things being undefined.

If it's your preference, we can close this now until I get time to dig into jekyll dev env setup a bit more, though I'm 98% confident this would fix the original issue.

Whatever you think is best, it's only a deprecation warning at any rate.

lpmi-13 commented 4 years ago

Gonna go ahead and close this for now...spent the last two days in the jekyll-hole making slight progress (jsyaml now actually loads the file and is recognized by jquery), but still not completely there with the implementation...plus there's other quick wins in terms of a11y and perf that would be a better use of time at the moment.