search

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

add alt tag for image #57

Closed lpmi-13 closed 4 years ago

lpmi-13 commented 4 years ago

this was affecting the lighthouse audit score for accessibility.

kingthorin commented 4 years ago

As the event is now over and the file is conflicting I think this PR can be closed.

lpmi-13 commented 4 years ago

I can address any conflicts in a few hours...is the same banner.html going to be used for next year? If so, might be good to add in the alt tag now so its ready to go.

kingthorin commented 4 years ago

I have no idea if it’ll be re-used. I believe the org kinda uses it in a rotational manner, ex: it already has new content (this time without an image).

lpmi-13 commented 4 years ago

Fair enough. Will close.

kingthorin commented 4 years ago

Thanks, for the contribution. Please don't let this discouage you from helping on other fronts.