search

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)
9 stars 26 forks source link

Using URL fragments causes pages to render empty #61

Closed kingthorin closed 4 years ago

kingthorin commented 4 years ago

No fragment: https://owasp.org/www-project-web-security-testing-guide/ image

With fragment: https://owasp.org/www-project-web-security-testing-guide/#stable image

kingthorin commented 4 years ago

Note: https://owasp.org/www-project-web-security-testing-guide/index.html#stable https://owasp.org/www-project-web-security-testing-guide/index#stable

Aren't any better.

kingthorin commented 4 years ago

Tested in latest Chrome and Firefox, haven't bothered with IE/Edge.

hblankenship commented 4 years ago

We use the fragments to find the tabs; I will look into making these work if the fragment isn't part of the tabs.

kingthorin commented 4 years ago

Thanks!

hblankenship commented 4 years ago

Give this a go. I believe it should be working provided that the repository in question is rebuilt against the updated site theme (which WSTG was re-built by me to test this). It may also require a refresh due to caching.

kingthorin commented 4 years ago

Seems to work, thanks @hblankenship!

https://owasp.org/www-project-web-security-testing-guide/#how-to-reference-wstg-scenarios

Just in-case anyone come across this later, of course it only works for the primary tab but I think that's fine for the majority of use cases.