Fix or Drop silly browser identification JS/Banner

OWASP / www--site-theme

Contains owasp site theme specific items (headers, footers, json, menus)

9 stars 26 forks source link

Fix or Drop silly browser identification JS/Banner #64

Closed kingthorin closed 4 years ago

kingthorin commented 4 years ago

No owasp.org actually I'm running Firefox 78.0.1!!!!

This seems to be another thing that suggests we need a testing plan/mechanism 👍

bkimminich commented 4 years ago

It can identify IE10, though... https://www.browserling.com/browse/win/7/ie/10/http%3A%2F%2Fowasp.org 😁

hblankenship commented 4 years ago

So very passionate.... The item that does that is javascript from browser-update.org. Personally, I would think we could remove it entirely because, if you are using an old browser, you should already know that your mileage my vary. Thought?

kingthorin commented 4 years ago

While it might be nice of us to suggest upgrades, it is even somewhat topical to the mission etc. If the component can't do it accurately then it seems to me more of a detractor than value add.

Plus I suspect the majority of visitors (as you suggested) will be aware that their browser of choice has limitations/support weaknesses.

Also I kinda wonder about the conversion/action rate on such banners. Does anyone do anything other than hit ignore and try to continue anyway?

hblankenship commented 4 years ago

removed browser update js. please note that it will take some time to propagate to all repos.