search

OWI-Lab / owimetadatabase-preprocessor

Basic processing of the data from owimetadatabase
https://owi-lab.github.io/owimetadatabase-preprocessor/
GNU General Public License v3.0
2 stars 1 forks source link

owt.all_cans should have a column specifying the subassembly #10

Closed wweijtje closed 6 months ago

wweijtje commented 6 months ago

the all_cans command should provide a column that specifies the sub assembly (i.e. Tower, MP, TP, ... ) . While this can currently be inferred from the can's name, that is just because we keep that convention there is no obligation to adhere to it. E.g. one can perfectly have an element ('bbc01_001')

I think when we are going to add tubular sections linked e.g. to the grout or other, that this will become very helpful.

wweijtje commented 6 months ago

This also applies for owt.all_distributed_mass and owt.all_lumped_mass

arsmlnkv commented 6 months ago

While this was added, another issue is that we use titles now to determine the sub assembly type from "raw" dataframes for processing. Because of that I thought it was a standard practice, i.e. fixed format for building blocks names...