search

OWI-Lab / owimetadatabase-preprocessor

Basic processing of the data from owimetadatabase
https://owi-lab.github.io/owimetadatabase-preprocessor/
GNU General Public License v3.0
2 stars 1 forks source link

owt.all_cans could be duplicated by owt.geometry #11

Closed wweijtje closed 8 months ago

wweijtje commented 8 months ago

I like the functionality of 'owt.all_cans' but feel like the name will be "hard to find" for people not familiar with our implementation (e.g. the word 'can' is rarely mentioned). As you have owt.tower_geometry -> owt.geometry might be a good substitute. For me you don't have to change anything in the behaviour, it is ok like this.

wweijtje commented 8 months ago

'owt.geometry' is just a suggestion btw if it doesn't fit with the other logic, I'm open to another name :-)

arsmlnkv commented 8 months ago

That's a good point and exactly what I thought recently when manually played with the package myself again. I just used the name since some people were referring to it like that (and even in the legacy code). I think something like owt.tubular_structures or owt.tubular_sections will be more explicit.

wweijtje commented 8 months ago

I think this fits with the main mission statement that this is a package for all users first and for us internally second. I.e. the current package should be clear to all users. With a small package in between/or some minor tweaks to make our own workflows work if acceptable.

arsmlnkv commented 8 months ago

I decided to go with owt.tubular_structures and, additionally, with the same logic, some other names were changed (see commit or release changelog).