search

OWI-Lab / owimetadatabase-preprocessor

Basic processing of the data from owimetadatabase
https://owi-lab.github.io/owimetadatabase-preprocessor/
GNU General Public License v3.0
2 stars 1 forks source link

owt.all_turbines return None when owt.process_structure() is not ran #9

Closed wweijtje closed 8 months ago

wweijtje commented 8 months ago

This is covered in the example notebook, but it was a bit weird to me that there was no warning or anything when I tried to run it without first running 'owt.process_structure()'

I understand that you want to avoid the timeconsuming step of the process_structures, but I would have expected a warning stating that process_structure had to be ran first

arsmlnkv commented 8 months ago

It is a valid point. I mainly followed the same logic as in the legacy code. Need to think about the best way to address that. I will try to maybe give some sort of warning for now indeed, but I will also keep this issue open until we agree on the best way.