search

OXIDprojects / oxid-console

OXID Community Console is a php console application for OXID Shop. It provides an API for writing various commands. We have shipped very common for every oxid shop project commands out of the box.
MIT License
7 stars 5 forks source link

added deactivate:module command #19

Closed alfredbez closed 4 years ago

alfredbez commented 5 years ago

fixes #18

We could abstract some code in ActivateModuleCommand and DeactivateModuleCommand, because there is some copy-paste-code in there.

alfredbez commented 4 years ago

For the record: The shop parameter is not needed since it is already defined here for all commands: https://github.com/OXIDprojects/oxid-console/blob/96fe880a47cdb3d6269f078543bb12618770fc45/src/Core/Application.php#L97-L111

I think it would be very helpful to provide such information in the commit message. A commit message like Update DeactivateModuleCommand.php (or several others) is bad for several reasons, I can't recommend this blog post enough: https://fatbusinessman.com/2019/my-favourite-git-commit

In this particular case the following commit message would be very helpful:

Remove shop-parameter from DeactivateModuleCommand

The shop-parameter is already defined in the Application class
see Application@getDefaultInputDefinition