OXIDprojects / oxid-console

OXID Community Console is a php console application for OXID Shop. It provides an API for writing various commands. We have shipped very common for every oxid shop project commands out of the box.
MIT License
7 stars 5 forks source link

Remove 's' shortcut for clear:cache command #26

Closed alfredbez closed 4 years ago

alfredbez commented 4 years ago

The shortcut 's' is already defined, so we just remove the shortcut see \OxidProfessionalServices\OxidConsole\Core\Application::getDefaultInputDefinition

This is a breaking change, maybe someone uses this in their deployment script or something similar.

This should fix #25

alfredbez commented 4 years ago

Looks like moduleinternals is broken:

[info] going to fix states in all shops
[info] oh oh
[info] Class 'OxidProfessionalServices\ShopSwitcher\ShopSwitcher' not found
##[error]Process completed with exit code 1.

@keywan-ghadami-oxid Do you know what the problem is?


I will remove the first commit from this PR for now, let's have the failing check first (second commit). I will add the commit again, after the bug is verified by CI.

alfredbez commented 4 years ago

Maybe the oxid-professional-services/lib-shop-switcher package should go into the require section instead of the require-dev section?