search

OXRS-IO / OXRS-IO-TouchPanel-ESP32-FW

OXRS compatible firmware for WT32-xxx touch screen displays
https://oxrs.io/docs/firmware/touch-panel-esp32.html
BSD 3-Clause "New" or "Revised" License
20 stars 3 forks source link

update thermostat tile (target/current temps) from "thermostat" object #28

Closed sumnerboy12 closed 2 years ago

sumnerboy12 commented 2 years ago

Previously you had to send both thermostat and number commands to keep the tile/popup in sync.

This change converts the thermostat values and updates the tile accordingly.

You might have a better way to handle the internal formatting?

sumnerboy12 commented 2 years ago

As discussed @MakerDockio - this will simplify the payload required, and therefore the docs. So might be best to wait for Moin's review before adding the thermostat tile to the docs.

moinmoin-sh commented 2 years ago

My design goal was,that when the setNumber was sent it should render correctly for number style as well as thumbnail, No need to care for the icon style. sending now the setNumber to a thumbnail it shows the large display. You will never use setNumber for the thermostat I guess. When value or subValue not given, 0.0 is displayed - should be blank. Now you have to set the subValue. In my implementation subValue (or value, or any units) can be left out and would be shown as if not there. User can decide what he wants to display on the thumbnail (could be different from the pop-up) Or the user might want to show something different on the subValue for the thumbnail. Now you have the same units for value and subValue. I think using the setNumber for the themostat tile is more flexible. If you are happy how it is I'm ok.