OXRS-IO / OXRS-IO-TouchPanel-ESP32-FW

OXRS compatible firmware for WT32-xxx touch screen displays
https://oxrs.io/docs/firmware/touch-panel-esp32.html
BSD 3-Clause "New" or "Revised" License
20 stars 3 forks source link

bug: in disable tile #35

Closed austinscreations closed 2 years ago

austinscreations commented 2 years ago

bug in #31 running Ethernet v1.6.1 sending {"tiles": [{"screen":1,"tile":1,"disable":1}]} more than once causes the tile to get continuously darker. but your only able to send {"tiles": [{"screen":1,"tile":1,"disable":0}]} once to bring the tile back to normal state - once doesn't work if your flow accidentally sends the payload to disable more than once.

MakerDockio commented 2 years ago

Just to confirm isn't the disable property value supposed to be a boolean?

cmnd/ payload {"tiles":[{"screen":"1", "tile":"1","disable":true}]}

cmnd/ payload {"tiles":[{"screen":"1", "tile":"1","disable":false}]}

austinscreations commented 2 years ago

Not as far as I could tell in code, and I wasn't getting a response for boolean false but it would act on true Same issue still persisted though if using boolean

sumnerboy12 commented 2 years ago

I think this is a valid bug - when sending "disable":true repeatedly it doesn't clear the existing foreground tile which provides the disabled/dimming effect. So it just keeps adding more of these foreground tile covers over the top of one another.