search

OXRS-IO / OXRS-IO-WEBSITE

Open eXtensible Rack System
BSD 2-Clause "Simplified" License
2 stars 11 forks source link

latest PR failed #52

Closed austinscreations closed 2 years ago

austinscreations commented 2 years ago

Making note that: NPM failure to rebuild oxrs.io in PR #51

https://github.com/OXRS-IO/OXRS-IO-WEBSITE/runs/7057593918?check_suite_focus=true

MakerDockio commented 2 years ago

Spoken with @MitchellR who is going to look into updating the build environment to get around the current NPM build issue.

mrinc commented 2 years ago

@austinscreations @MakerDockio - she is fixed... that was a fun one!

Added a bunch of other touchups as well like validating the paths and names for the nav and sidebar due to issues with it displaying at all. So that and search is working again. Build is working.

Let me know :)

austinscreations commented 2 years ago

Thanks for doing that @mrinc - I've been trying to keep up on the side bar and top bar navigation and to keep it functional in a logical way.

Glad it can be working again as we'll be having another large push of updates somewhat soon.

mrinc commented 2 years ago

The sidebar does seem to be a bit of a pain to keep up with... We could maybe change the way its loaded to make it easier to manage. So instead of managing the sidebar in the config.sidebar.js file (new file) - we move one to each of the main folders. So like inside the docs folder, there is a sidebar file there This would allow for a bit easier to manage context wise me thinks.

Nav bar doesn't change too much (well shouldn't have to) compared to the sidebar

What do you think?

austinscreations commented 2 years ago

i just double checked and the nav bar seems to be working the way we want so i'd say leave it as is.

edit: i just realized i don't think the changes have been pushed live to the site. just saw the open PR. i'll give it a test locally to confirm same behavior.

mrinc commented 2 years ago

In order to fix the build I had to do a bunch of stuff and during so noticed the nav bar some how stopped working. But you will notice the search now works - which it didn't before (due to a breaking config change).... just no one noticed it lol

So thus why the split of the config files.

But yea, it's not live since PR - but make sure you npm i once you pull it down since package changes Ideally, clear all temp files and then npm i, and run the project.