Closed dweston closed 2 years ago
Reads really well and thanks for your efforts. I'll let another person review before merging @sumnerboy12 you happy with this?
I'm also happy for you @dweston to take a crack at macos / ethernet. In my opinion it would be nice if we could unify the installation steps to cover all scenarios so not bloat the instructions with multiple versions with slight differences, maybe highlighting any differences with platform / method i.e. wifi vs ethernet in each step in brackets or something.
Take your point on bloat.
I’m reasonably technically aware but still find I struggle with the finer points. Minor issues took me significant time to resolve (AKA that the web server code for the WiFi AP set-up would not render properly on a FireFox browser - it requires Chrome).
Hence I opted to really spell out the detail to ease the way for others who may follow.
On 17 Oct 2022, at 14:41, Aaron Knox @.***> wrote:
Reads really well and thanks for your efforts. I'll let another person review before merging @sumnerboy12 https://github.com/sumnerboy12 you happy with this?
I'm also happy for you @dweston https://github.com/dweston to take a crack at macos / ethernet. In my opinion it would be nice if we could unify the installation steps to cover all scenarios so not bloat the instructions with multiple versions with slight differences, maybe highlighting any differences with platform / method i.e. wifi vs ethernet in each step in brackets or something.
— Reply to this email directly, view it on GitHub https://github.com/OXRS-IO/OXRS-IO-WEBSITE/pull/73#issuecomment-1280237903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2DSIRDWSAI2DTZ6UIBALWDTDIBANCNFSM6AAAAAARGTSLRU. You are receiving this because you were mentioned.
Sure - I’ll fix shortly and push.
Took a bit of effort to set up dev environment but seems to be playing ball now. Am using VSCode which seemed to cough a bit gaining authorisation from GitHub.
On 17 Oct 2022, at 18:40, Ben Jones @.***> wrote:
@sumnerboy12 approved this pull request.
One very minor suggestion, but otherwise it looks great. Thanks!
In docs/docs/firmware/touch-panel-esp32.md:
@@ -2400,6 +2402,27 @@ Custom icons are not persistent and have to be (re)loaded after restart and
- Icons are aligned top/left of a tile
- There are no size checks for custom icons
+## Firmware Installation + +### Initial Set-up – Windows 10 +Workflow to commission a new Touch Panel: +1. Download the most recent wifi or ethernet version of the compiled oxrs-io-touchpanel-esp32-fw firmware to a work folder created for the commissioning process. Could we match the case of the release binary files generated - i.e. OXRS-IO-TouchPanel-ESP32-FW.*?
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
If this is of use to everyone I'll have a go at embellishing this with a version for Ethernet and also for set-up on macOS.