OXY2DEV / markview.nvim

An experimental markdown previewer for Neovim
Apache License 2.0
1.17k stars 33 forks source link

Image submission #50

Closed OXY2DEV closed 1 week ago

OXY2DEV commented 1 month ago

If you have screenshots that you want to put in the README(and the wiki if relevant) then you can post them here.

The image should be any of the following types.

scottmckendry commented 1 month ago

Hello @OXY2DEV! Submitting the first demo image on this thread. Heres markview.nvim with all stock settings combined with cyberdream.nvim:

image

OXY2DEV commented 1 month ago

image

I just realized that horizontal rules don't consider textoff. Anyway, I fixed the issue now.

Can you take a new screenshot, @scottmckendry ?

scottmckendry commented 1 month ago

Oh nice, thanks for that quick fix! I've updated my comment with a new screenshot 🙂

OXY2DEV commented 1 month ago

Oh nice, thanks for that quick fix! I've updated my comment with a new screenshot 🙂

Yep, much better.

nebunebu commented 1 month ago

callouts

checkboxes

codeblocks

headings

tables

OXY2DEV commented 1 month ago

callouts

checkboxes

codeblocks

headings

tables

Thanks for sharing these screenshots!

I am currently busy so I haven't been able to do much. So, it may take a while before images are added.

These images will be added to the wiki pages.

mosheavni commented 1 month ago

you better not host the images on the repo. check out: https://www.reddit.com/r/neovim/comments/wsg5yx/attention_to_all_plugin_authors_newcomers_careful/

OXY2DEV commented 1 month ago

you better not host the images on the repo. check out: https://www.reddit.com/r/neovim/comments/wsg5yx/attention_to_all_plugin_authors_newcomers_careful/

They are mostly stored in the wiki repo. So, I don't think anyone will know or accidentally download them.

Plus, there will be a different branch for images(as GitHub generated links break after a while) when thre are more images.

mosheavni commented 1 month ago

you better not host the images on the repo. check out: https://www.reddit.com/r/neovim/comments/wsg5yx/attention_to_all_plugin_authors_newcomers_careful/

They are mostly stored in the wiki repo. So, I don't think anyone will know or accidentally download them.

Plus, there will be a different branch for images(as GitHub generated links break after a while) when thre are more images.

everyone downloads them when they install this plugin in their neovim setup. most plugin managers do a shallow clone of the repo and that contains the images.

image

admittedly they are less than 1 MB but we don't need even this 1 MB on our laptops.

OXY2DEV commented 1 month ago

you better not host the images on the repo. check out: https://www.reddit.com/r/neovim/comments/wsg5yx/attention_to_all_plugin_authors_newcomers_careful/

They are mostly stored in the wiki repo. So, I don't think anyone will know or accidentally download them. Plus, there will be a different branch for images(as GitHub generated links break after a while) when thre are more images.

everyone downloads them when they install this plugin in their neovim setup. most plugin managers do a shallow clone of the repo and that contains the images. image

admittedly they are less than 1 MB but we don't need even this 1 MB on our laptops.

Screenshot_2024-07-29-13-35-38-758_com termux-edit

Actually ~3MB of images but those aren't downloaded.

mosheavni commented 1 month ago

you better not host the images on the repo. check out: https://www.reddit.com/r/neovim/comments/wsg5yx/attention_to_all_plugin_authors_newcomers_careful/

They are mostly stored in the wiki repo. So, I don't think anyone will know or accidentally download them. Plus, there will be a different branch for images(as GitHub generated links break after a while) when thre are more images.

everyone downloads them when they install this plugin in their neovim setup. most plugin managers do a shallow clone of the repo and that contains the images. image admittedly they are less than 1 MB but we don't need even this 1 MB on our laptops.

Screenshot_2024-07-29-13-35-38-758_com termux-edit

Actually ~3MB of images but those aren't downloaded.

if you can do this hack also to images folder, that would be best.

github-actions[bot] commented 1 week ago

Stale issue message