OakCH / scheduler

Vacation Scheduler for the Oakland Children's Hospital
7 stars 10 forks source link

Flash: iterate over set flash values #49

Closed helenaut closed 12 years ago

helenaut commented 12 years ago

For ordering purposes. rx recommended it?? idk if it's actually necessary at this stage.

sheel: It's a pretty easy fix with the code we have, just throw in a .sort before the .each and the ordering will always be the same.

sheelc commented 12 years ago

I'm not following what he's suggesting? Does he mean enforce that we always render :error before :notice?

helenaut commented 12 years ago

Yeah. Our current implementation is a tossup since we just iterate through the keys of the flash hash. I think he's suggesting we instead iterate over a set array like [:notice,:error] so we can get a specific ordering.

This is kind of low priority though I think.

sheelc commented 12 years ago

It's a pretty easy fix with the code we have, just throw in a .sort before the .each and the ordering will always be the same.

helenaut commented 12 years ago

oh hmm I like that. updating the description.