search

OasisDEX / oasis

Oasis - Decentralized Token Market
http://oasisdex.com/
Apache License 2.0
170 stars 56 forks source link

Warning message not the best offer #165

Open gbalabasquer opened 7 years ago

gbalabasquer commented 7 years ago

Add Warning message when user tries to take not the best offer

gbalabasquer commented 7 years ago

@pimato We would need the correct styles for this implementation.

image

pimato commented 7 years ago

I will create something till tomorrow .

pimato commented 7 years ago

Okay, planed was one day, but it took me three days. Sorry for the delay :

new_popup

gbalabasquer commented 7 years ago

@pimato Thanks. I made the icon with no background and border red as was the only I could do modifying the svg. We can replace for the definitive one later. Also I left the text that Andy had originally sent to me.

pimato commented 7 years ago

while my modal is getting displayed I can see the Icon also showing up, is it possible to fix that ? (So I don`t see the Icon popping up ?

ghost commented 7 years ago

Will this warning be necessary the moment we introduce automated order matching? I mean, won't it become redundant are direct buy/sell will go away?