OasisDEX / oasis

Oasis - Decentralized Token Market
http://oasisdex.com/
Apache License 2.0
170 stars 56 forks source link

Detect pending transactions that fail #8

Open c055 opened 8 years ago

c055 commented 8 years ago

@jorisbontje:

"Tried to place an order and got an "out of gas" error, which the UI did not communicate to me. (It's stuck on "Your order is being placed...")"

We should detect if a transaction fails and give some kind of feedback to the user; even if we can't figure out why it happened.

(ported from https://github.com/MakerDAO/maker-otc/issues/38)

c055 commented 8 years ago

@jorisbontje:

Related to #43 - https://github.com/MakerDAO/maker-otc/issues/43

c055 commented 8 years ago

@jorisbontje:

This is implemented, with the exception when you have multiple pending transactions where during the processing of these you run out of ETH.