OasisLMF / ODS_OpenExposureData

Open data standards curated by Oasis.
61 stars 8 forks source link

Step policy Extra expenses and Debris removal factor default value should be 0 #100

Closed johcarter closed 5 months ago

johcarter commented 1 year ago

We'd like to request that the default values for ExtraExpenseFactor and DebrisRemovalFactor be changed to 0 from 1, and values of 0 allowed please @MattDonovan82 .

The reason is that these factors are applied as an uplift factor to losses, and so they increase the loss for factors greater than 0.

If there is no factor provided, i.e. blank field in the account file, then the value of 0 is the correct default. This is also the default we assign in the Oasis FM code so changing the OED spec will bring us in line.

FYI @sstruzik image image

MattDonovan82 commented 1 year ago

so just the two defaults to be changed @johcarter @sstruzik?

We will look to get this included into OED v3.0.0 in Jan 2023 so please add anymore requests if necessary.

sstruzik commented 1 year ago

here is the list of change I'm proposing to put OED schema.

for ExtraExpenseFactor and DebrisRemovalFactor, change default from 1 to 0 and remove max (was 1)

in practice in OasisLMF a factor of x mean that the loss will be multiply by 1+x. So for a loss l is you want no ExtraExpenseFactor you need to set it to 0, We also considered that there was no reason for those factor to be capped to 1, clearing debris after a catastrophe can cost much more than the value of a building (ex: Chernobyl power plant)

NumberOfBuildings set min from 1 to 0

new meaning, 0 is for unknown number of buildings

MattDonovan82 commented 1 year ago

for clarity, the default for NumberOfBuildings will remain as 1 but the user will be able to put in zero if unknown?

johcarter commented 1 year ago

yes thats right

MattDonovan82 commented 1 year ago

Closed as included in OED v3.0.0

aiste-kalinauskaite commented 7 months ago

Descriptions and valid value ranges no longer match up and contradict each other. If you want to keep the change of valid value range to go above 1, then the descriptions need to be updated (specifically this bit to be removed: "and must be a value >0 and ≤1").

MattDonovan82 commented 6 months ago

@aiste-kalinauskaite I can include the following comment in the description for NumberofBuildings "Default to 1 but user should enter '0' if unknown".

However, I'm not sure I understand your comment above regarding the ExtraExpenseFactor and DebrisRemovalFactor which currently state "must be a value >0. For example, 0.12 for 12%."

Where is it mentioned "and must be a value >0 and ≤1" ?

johcarter commented 6 months ago

I don't see this discrepancy for ExtraExpenseFactor and DebrisRemovalFactor in the latest spec - descriptions and valid values are consistent. @aiste-kalinauskaite could you please check you are looking at v3.1.0 spec? please confirm and we can close this issue. thanks

aiste-kalinauskaite commented 5 months ago

@johcarter , @MattDonovan82 I have reviewed this against v3.0.0 when I raised the previous comment and it has been corrected in v3.1.0. So I will close it.