Open johcarter opened 4 months ago
Fallback occupancy code for new marine cargo codes set to 1100 general commercial in 'Versioning' table, unless anyone can think of a more suitable fallback ? fyi @MattDonovan82
There are some outstanding tasks to do which are now blocking the release.
Given that marine cargo has no special field requirements (other than commodity fields, which have been added for property) and is a subset of property fields, I think we could backlog them and go with marine cargo as part of the property class for v4, and perhaps give a marine cargo example in the examples folder as guidance for users.
We could later add a separate column for marine cargo when the requirement to split it out as a separate class is proven. What do you think @MattDonovan82 ?
Reference file for implementation:
OED_Marine_Cargo_Data_Spec_v0.0.10.xlsx
A few changes were made to the list of fields as follows;
Added
Reason: omissions from original list which should be included.
Removed
Reason: this field is only needed for location specific terms and conditions i.e. LocDed{}, LocLimit{} fields, which are all n/a / not supported
Following further conversations, adding a marine cargo column now was agreed as it explicitly sets out what fields for marine cargo are supported (even if that doesn't differentiate from the property fields at the moment).
Tasks to integrate the Marine Cargo exposure class into OED Fields will be a selected subset of property fields plus a few new ones.
Reasons for change
To support Marine Cargo as a distinct exposure class in integrated OED v4 and later. ## Scope of change - [X] Specification - [X] Location File - [ ] Accounts File - [ ] Reinsurance Scope - [ ] Reinsurance Info ## Impact of change Breaking only as part of major specification restructuring. ## Data type, default values, are blanks allowed, list valid values Commodity codes to categorize type of cargo/stock The initial scheme is HS22, or user defined pre-fixed with X. https://www.wcoomd.org/en/topics/nomenclature/instrument-and-tools/hs-nomenclature-2022-edition.aspx | **Field Name** | **Data type** | **Default values** | **Valid values** | |-----------------|---------------|--------------------|---------------------| | CommoditySchemeXX | varchar(5) | n/a | | | CommodityCodeXX | varchar(10) | n/a | | | CommodityVintageXX | smallint | 0 | [0,) | New occupancy code list to be proposed (work in progress).