search

OasisLMF / ODS_OpenExposureData

Open data standards curated by Oasis.
61 stars 8 forks source link

Should 'OEDVersion' be a required field? #203

Closed MattDonovan82 closed 2 months ago

MattDonovan82 commented 3 months ago
## Description

Should the OEDVersion field in all four OED input files be a 'required' field?

Reasons for change

Currently an optional field but making it 'Required' ensures a solid reference to the version of OED. Its' been discussed as a possibility and so I'm just putting it out there for the community to comment and get some feedback. ## Scope of change - [X] Location File - [X] Accounts File - [X] Reinsurance Scope - [X] Reinsurance Info ## Impact of change This will be a breaking change for most validation exercises so it will go into OED v4.0.0 which is a major update. ## Data type, default values, are blanks allowed, list valid values | **Field Name** | **Data type** | **Default values** | **Blanks allowed** | **Valid values** | |----------------|---------------|--------------------|--------------------|------------------| | Acc; Loc; ReinsInfo; ReinsScope | Varcher(10) | Latest version of OED | No | 4.0.0 | | | | | | |
MattDonovan82 commented 3 months ago

Just to bring it to your attention @johcarter @benhayes21 @sstruzik @aiste-kalinauskaite

MattDonovan82 commented 2 months ago

Further discussions suggest this should remain an 'optional' field as it will cause too much disruption to make it 'required' and it's not ideal to have this for every row of data in all four files. There was an idea to include this in the model settings file instead.

Any further comments @sstruzik @johcarter @benhayes21 ?