OasisLMF / ODS_OpenExposureData

Open data standards curated by Oasis.
61 stars 8 forks source link

Adding new occupancy and construction classes to OED #58

Closed unnithan9 closed 2 years ago

unnithan9 commented 2 years ago

Hi, We would like to suggest some of the occupancy and construction class that are missing in OED. Please find attached the pdf having some of the missing occupancy and construction classes . It would be great if you can review the proposed OED codes and suggest some for the missing class. OED Class.pdf Thanks Vipin

MattDonovan82 commented 2 years ago

Hi @unnithan9 In general these suggestions looks reasonable but I do have a few questions/suggestions below just so we are definitely not duplicating codes/descriptions.

Occupancy:

Construction:

I suggest if your proposed codes are to cover buildings that are of a 'higher performance' to wind, I would name them as such and in the description mention why they are different to the proposed codes/descriptions? For example, yours could be called:

In general, we just need to differentiate with existing codes. All the other proposed codes look fine.

Open to suggestions from others.

Matt

unnithan9 commented 2 years ago

Hi Matt,

Occupancy:

Construction:

Yes, like you said the proposed codes are meant to cover buildings that are of a 'higher performance' to wind, which generally do not undergo much damage. We will name it like the one you suggested and give a detailed description.

Can you also please look into Basement Loss Sensitive code, which are primarily used in Flood.

Thanks Vipin

MattDonovan82 commented 2 years ago

Thanks. A more detailed description of the proposals will be appreciated.

It seems these 'high performance' codes should be kept together so a slight amendment might be

MattDonovan82 commented 2 years ago

As discussed offline, until these codes are released into the schema as a version update (will be v2.1.0), the use of these new codes cannot be deployed externally and should only be used for your own internal model testing/usage. If so, it would cause validation processes to fail as these new codes would not be present in previous versions of OED.

unnithan9 commented 2 years ago

Yes we will be providing a detailed description for the proposed codes, and I do understand that this can be used for internal model testing/usage until this makes into the schema as a version update. Thank you Matt for the support!

-Vipin

MattDonovan82 commented 2 years ago

@unnithan9 Please add the detailed descriptions and all codes of what will be included in the schema to this Issue (can be another attachment if thats easier), to keep it all together and open for others to comment. thanks.

unnithan9 commented 2 years ago

Hi Matt,

Please find attached the pdf which includes the proposed codes, names and a detailed description of each class. Please let me know if you need any additional information OED.pdf

Thanks for the support.

-Vipin

MattDonovan82 commented 2 years ago

@unnithan9 please review the additions you proposed in the data spec.xlsx of the develop brach below. They will be included in the v2.1 release in the next week. Thanks. https://github.com/OasisLMF/OpenDataStandards/tree/develop/OpenExposureData/Docs

unnithan9 commented 2 years ago

Hi @MattDonovan82 I have reviewed the proposed additions in the xls file, and it looks fine. Thank you for the support.

-Vipin

MattDonovan82 commented 2 years ago

included in v2.1