search

OasisLMF / ODS_OpenExposureData

Open data standards curated by Oasis.
61 stars 8 forks source link

add data types to ORD Specification #66

Closed benhayes21 closed 2 years ago

benhayes21 commented 2 years ago

add data types to ORD Specification

MattDonovan82 commented 2 years ago

To confirm it would be data types for each column header in each ORD output similar to OED?

MattDonovan82 commented 2 years ago

The data types in the attached look ok to me. Any further comments @hchagani-oasislmf @benhayes21 ?

ORD_DataTypes_v0.1.xlsx

hchagani-oasislmf commented 2 years ago

Thanks. They look fine to me.

MattDonovan82 commented 2 years ago

@johcarter ORD_Data_Spec_v0.1.xlsx

I've added the tab for the data types into the ORD data spec attached but this spec seems a bit outdated (the 'list of Fields' tab specifically). Fields such as the multiple 'impacted locs' are not included in the ORD outputs. Do you think the 'List of Fields' tab should be updated or just removed? Columns E and F in particular probably need reviewing.

johcarter commented 2 years ago

Looks good @MattDonovan82.

Regarding the fields question, Impacted Locations has not been implemented yet so those fields are fine to stay in the spec. The 'List of Fields' tab also includes the json fields which we need to keep. It will probably need revising when we implement the whole ORD package.

MattDonovan82 commented 2 years ago

ok, so you think the whole spec file its fine to leave as it is for now?

johcarter commented 2 years ago

Yes

MattDonovan82 commented 2 years ago

I'll upload to the dev branch and we can review when the full ORD package is ready.

MattDonovan82 commented 2 years ago

closed as implemented in v2.3.0