Open niamhomalleyjba opened 2 weeks ago
Looks like it might be the OED spec that is incorrect for BaseFloodElevation
. Unclear why it would be restricted to [0,1]. Should it's valid value range instead be [-999,)
, similar to FloodDefenseHeight
or BuildingHeight
? Possibly there was some confusion due to the fact that the description mentions a probability.
Looks like it might be the OED spec that is incorrect for
BaseFloodElevation
. Unclear why it would be restricted to [0,1]. Should it's valid value range instead be[-999,)
, similar toFloodDefenseHeight
orBuildingHeight
? Possibly there was some confusion due to the fact that the description mentions a probability.
I've reported this at https://github.com/OasisLMF/ODS_OpenExposureData/issues/225.
Issue Description
The `BaseFloodElevation` column contains values that are not in the valid value range of the OED specification (`[-999,-999], [0,1]`). Potentially linked to '[Transformation tool: column headers are repeated in column values](https://github.com/OasisLMF/ODS_Tools/issues/153)'? ## Steps to Reproduce (Bugs only)Config file:
Command used:
Output is created but the
BaseFloodElevation
column contains the values from the original CEDE data. They have not been converted to be within the OED range. For example the following values are present-999 370 161 31 14 404 515 6 49 336 28 53 175 16 8 167 7 1451 209 34 159 1069 326 10 66 733 4 33 9 1 27 171 1378 727 5 341 56 11 90
- out of these, it should only be-999
and1
- the rest should be converted?Version / Environment information
Name: ods_tools Version: 3.2.7
Example data / logs