OasisLMF / OasisDataManager

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

The typing package is only required in Python 3.5 (or lower) #15

Closed sambles closed 1 month ago

sambles commented 1 month ago

Issue Description

Remove typing from package requirements it's only required for Python <3.5

This can cause the following error when packages are added to the base model_worker image:

#11 0.362 Traceback (most recent call last):
#11 0.362   File "/usr/bin/pip", line 5, in <module>
#11 0.362     from pip._internal.cli.main import main
#11 0.362   File "/usr/lib/python3/dist-packages/pip/__init__.py", line 1, in <module>
#11 0.362     from typing import List, Optional
#11 0.362   File "/home/worker/.local/lib/python3.10/site-packages/typing.py", line 1359, in <module>
#11 0.362     class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
#11 0.362   File "/home/worker/.local/lib/python3.10/site-packages/typing.py", line 1007, in __new__
#11 0.362     self._abc_registry = extra._abc_registry
#11 0.362 AttributeError: type object 'Callable' has no attribute '_abc_registry'

Test that the worker requirements file no longer pulls typing once ODM is updated