search

OasisLMF / OasisUI

User Interface for the Oasis platform.
BSD 3-Clause "New" or "Revised" License
16 stars 17 forks source link

Incorrect validation summary graph #280

Closed sambles closed 1 year ago

sambles commented 2 years ago

Issue Description

The summary validation graph is not matching the table, the only bar shown is the noreturn TIV amount.

Screenshot 2022-03-16 at 11 45 45

Version / Environment information

UI: 1.11.3 Oasis: 1.24.0

MattDonovan82 commented 2 years ago

I would even consider removing this graph altogether. I'm not sure it brings any value to the user?

Especially as the exposure summary info is presented in the table above.

If it is going to remain (for those that would export it as a .png for reporting purposes) , the axes will have to be better labelled and it will have to be a much clearer graph in general.

sambles commented 2 years ago

It might be helpful as a quick visual breakdown to see roughly where the portfolio falls between success / nomatch / noreturn / fail

As it is the x axis doesn't makes much sense, at least to me, I don't think it needs number of locations or tiv

benhayes21 commented 2 years ago

looks like the table is duplicating the json data not sure that a graphical representation is required - unless you can think of a good way of representing it

benhayes21 commented 2 years ago

https://github.com/OasisLMF/OasisPiWind/blob/master/tests/inputs/SourceLocOEDPiWind.csv

RolandASc commented 2 years ago

the original issue here is that the graph wasn't adapted when more detailed return statuses were introduced. I am now fixing that first, then we can maybe re-consider

in general I do think that the percentages in the graph are useful to see that 80% of the locations were successful while that corresponds to only 65% of TIV being successful (for example)

benhayes21 commented 1 year ago

Ben to test