Error loading analyses listing page after creating analysis with custom files uploaded

nicksamps commented 2 years ago

Issue Description

It seems that if we have mix of analyses that do and don't have files uploaded during the "Customize Model" step, then the analysis listing page fails to load

Steps to Reproduce (Bugs only)

Create an Analysis with a file uploaded during the customize model steps
Create an Analysis without a file uploaded during the customize model steps
Refresh analysis listing page

Version / Environment information

Docker on Linux

coreoasis/oasisui_app:1.11.1 coreoasis/api_server:1.23.10

Example data / logs

server_1          | DEBUG 2022-05-17 11:02:28,079 http_protocol 107 140533339035456 HTTP 200 response started for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,079 http_protocol 107 140533339035456 HTTP close for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,079 http_protocol 107 140533339035456 HTTP response complete for ['172.18.0.3', 57618]
oasis-ui_1        | Warning: Error in : Can't combine `..1$complex_model_data_files` <list> and `..2$complex_model_data_files` <character>.
oasis-ui_1        |   [No stack trace available]
server_1          | DEBUG 2022-05-17 11:02:28,115 http_protocol 107 140533339035456 HTTP b'GET' request for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,116 selector_events 107 140531768526592 Using selector: EpollSelector
server_1          | INFO 2022-05-17 11:02:28,147 middleware 107 140531768526592 GET /v1/analyses/2/lookup_validation_file/
server_1          | ERROR 2022-05-17 11:02:28,147 middleware 107 140531768526592 {'Host': 'server:8000', 'User-Agent': 'libcurl/7.68.0 r-curl/4.3.1 httr/1.4.2', 'Accept-Encoding': 'deflate, gzip, br', 'Accept': 'application/json', 'Authorization': '*****'}
server_1          | ERROR 2022-05-17 11:02:28,147 middleware 107 140531768526592 b''
server_1          | INFO 2022-05-17 11:02:28,147 middleware 107 140531768526592 GET /v1/analyses/2/lookup_validation_file/ - 404
server_1          | ERROR 2022-05-17 11:02:28,147 middleware 107 140531768526592 {'Content-Type': 'application/json', 'Allow': 'GET, HEAD, OPTIONS'}
server_1          | ERROR 2022-05-17 11:02:28,147 middleware 107 140531768526592 b'{"detail":"Not found."}'
server_1          | WARNING 2022-05-17 11:02:28,148 log 107 140531760133888 Not Found: /v1/analyses/2/lookup_validation_file/
server_1          | DEBUG 2022-05-17 11:02:28,149 http_protocol 107 140533339035456 HTTP 404 response started for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,149 http_protocol 107 140533339035456 HTTP close for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,149 http_protocol 107 140533339035456 HTTP response complete for ['172.18.0.3', 57618]
oasis-ui_1        | Warning in value[[3L]](cond) : Not Found (HTTP 404).
oasis-ui_1        | Warning in self$api_handle_response(response) :
oasis-ui_1        |   Client error in api_handle_response, valid query but API did not find / return the requested resource.
oasis-ui_1        | Warning: Expected 4 pieces. Missing pieces filled with `NA` in 1 rows [1].
server_1          | DEBUG 2022-05-17 11:02:28,180 http_protocol 107 140533339035456 HTTP b'GET' request for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,181 selector_events 107 140531768526592 Using selector: EpollSelector
server_1          | INFO 2022-05-17 11:02:28,218 middleware 107 140531768526592 GET /v1/analyses/2/lookup_errors_file/
server_1          | ERROR 2022-05-17 11:02:28,218 middleware 107 140531768526592 {'Host': 'server:8000', 'User-Agent': 'libcurl/7.68.0 r-curl/4.3.1 httr/1.4.2', 'Accept-Encoding': 'deflate, gzip, br', 'Accept': 'application/json', 'Authorization': '*****'}
server_1          | ERROR 2022-05-17 11:02:28,218 middleware 107 140531768526592 b''
server_1          | INFO 2022-05-17 11:02:28,218 middleware 107 140531768526592 GET /v1/analyses/2/lookup_errors_file/ - 404
server_1          | ERROR 2022-05-17 11:02:28,218 middleware 107 140531768526592 {'Content-Type': 'application/json', 'Allow': 'GET, HEAD, OPTIONS'}
server_1          | ERROR 2022-05-17 11:02:28,218 middleware 107 140531768526592 b'{"detail":"Not found."}'
server_1          | WARNING 2022-05-17 11:02:28,219 log 107 140531760133888 Not Found: /v1/analyses/2/lookup_errors_file/
server_1          | DEBUG 2022-05-17 11:02:28,219 http_protocol 107 140533339035456 HTTP 404 response started for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,219 http_protocol 107 140533339035456 HTTP close for ['172.18.0.3', 57618]
server_1          | DEBUG 2022-05-17 11:02:28,220 http_protocol 107 140533339035456 HTTP response complete for ['172.18.0.3', 57618]
oasis-ui_1        | Warning in value[[3L]](cond) : Not Found (HTTP 404).
oasis-ui_1        | Warning in self$api_handle_response(response) :
oasis-ui_1        |   Client error in api_handle_response, valid query but API did not find / return the requested resource.
oasis-ui_1        | updating result$anaID because submodulesList$step2_chooseAnalysis$analysisID() changed to: 2

benhayes21 commented 2 years ago

Ben to reproduce on Mirai Test Server

RolandASc commented 1 year ago

@benhayes21 any update on this? could we get this model set up on our test server for validating a potential fix? Otherwise I could also just push a tentative fix and users could re-test?

OasisLMF / OasisUI