OasisLMF / OasisUI

User Interface for the Oasis platform.
BSD 3-Clause "New" or "Revised" License
16 stars 17 forks source link

UI crash at output dashboard with zipped exposure files #286

Closed sambles closed 1 year ago

sambles commented 2 years ago

Issue Description

Output Dashboard gray screen crashes when loading results from run using zipped exposure run (PiWind)

Version / Environment information

Oasislmf: 1.26.0 Platform branch: platoform-2.0-develop (Azure) OasisUI: 1.11.3

Example data / logs

input$dt_analyses_rows_selected is changed to: 1
analysisId changed to 6
selected analysis ID is 6
updating result$dashboardanaID because submodulesList$step3_configureOutput$dashboardAnaID() changed to: 6
Navigate to Single browse
replacing icons
Updating preselected row because anaID() changed to 6
updating ana outputs data list
Warning in FUN(X[[i]], ...) : NAs introduced by coercion
Warning: Error in : Invalid: Parquet magic bytes not found in footer. Either the file is corrupted or this is not a parquet file.
  2: runApp
  1: oasisui::runOasisui
delete  

piwind_loc_oed.zip piwind_acc_oed.zip

RolandASc commented 2 years ago

the crash happens because we read some data from the location file in order to produce the summary tab, and we haven't added any generic functionality to handle zipped exposure files

RolandASc commented 2 years ago

it was simple enough to add some code to handle zipped exposure files in the main function retrieving that data, so I have implemented that and this issue is resolved now

it doesn't mean that we will have full feature support for zipped files across the board though, so maybe we'll want to do something more later

MattDonovan82 commented 2 years ago

@mtazzari would the functionality you mentioned last week regarding splitting the tar files help here?

The UI is generally slow when trying to export or even view the output files, especially if they are quite large.