Feature/284 reuse settings plus bugfixes

OasisLMF / OasisUI

User Interface for the Oasis platform.

BSD 3-Clause "New" or "Revised" License

16 stars 17 forks source link

Feature/284 reuse settings plus bugfixes #289

Closed RolandASc closed 2 years ago

RolandASc commented 2 years ago

closes #284 fixes #279 fixes #281 partially addresses #266

Analysis settings templates functionality

Allows to select a previously saved analysis settings template (attached to the same model) in the output configuration step. When the analysis is ready to execute, the settings can also be saved as a new settings template. In addition, setting templates can be managed by deleting obsolete ones.
Fixes a bug downloading files of certain formats.

RolandASc commented 2 years ago

thanks for the testing and feedback @sambles.

it looks like with the first point you have actually run into #281 , so I'll check that and hopefully we can close that issue together with this PR :+1:

sambles commented 2 years ago

I also noticed the loss output log file generated by the worker 1.26.0 was quite large for a text file (its a Platform issue and not really UI related)

But that seemed to cause the UI slow downs when displaying the logs. Not really unexpected, but something to watch out for.

The file was around 44Mb~ (350k lines, mostly of numba debug logs)

RolandASc commented 2 years ago

yes, indeed, I have observed that as well, rendering such large log files slows the UI down a lot, which the user may interpret as the UI freezing

would have to check if we could do something like a line-count first to address this (possibly separate issue)

RolandASc commented 2 years ago

@sambles I fixed the additional issues with log files spotted during testing in f845d85