search

OasisLMF / OasisUI

User Interface for the Oasis platform.
BSD 3-Clause "New" or "Revised" License
16 stars 17 forks source link

Model Parameters in output config not reloading between analyses #299

Closed benhayes21 closed 1 year ago

benhayes21 commented 1 year ago

**IMPORTANT: Please apply the relevant labels, for example if this issue is needed as a backported fix add the label LTS fix (Long term support fix)

Issue Description

when creating a new analysis and navigating to the output screen, the details from the previous analysis are cached

Steps to Reproduce (Bugs only)

  1. create an analysis
  2. run it
  3. create a new analysis on a different model
  4. inspect the output settings image

Version / Environment information

1.11.5rc1

Example data / logs

RolandASc commented 1 year ago

If the model doesn't have any specific params, i.e. no event set, event occurrence and no other custom additional params, we currently skip the reloading here. This can be fixed easily.

A separate issue is that we do not clear / update the entries for the generic params loss threshold and the 3 new list config elements. Shall we do this in any case (re-run, template, new), or is there a purpose of keeping them when switching to a new analysis that doesn't have any previous configuration yet? Because maybe someone would like to keep running with the same set of values for the 3 new list configs?

Either way is fine from an implementation perspective, just let me know @benhayes21

benhayes21 commented 1 year ago

i think clear it