OasisLMF / ReinsuranceTestTool

Test tool for new reinsurance functionality.
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

error PortNumber is not an integer #60

Closed johcarter closed 5 years ago

johcarter commented 5 years ago

In dev branch using example LOC_PR_filter_P2; Example tries to filter a Location Per Risk Treaty on PortNumber = P2

Error: [{'check': 'datatypes', 'scope': 'ri_info file', 'messsages': ["Type error in column 'PortNumber': expected '[dtype('int64'), dtype('float64')]' found 'object'"], 'meta_data': ''}] Exec time: 0.2039628028869629

despite the misleading field name, PortNumber is a varchar field not an int.

johcarter commented 5 years ago

Also, filtering on PortNumber alone (when it is an integer) runs but does not seem to take effect. Both portfolios in this example have losses.

mpinkerton-oasis commented 5 years ago

PortNumber is not implemeneted yet as a scope or filter.

(also, can we log different points as separate issues so we track independently)

johcarter commented 5 years ago

ok will create a new issue for this

mpinkerton-oasis commented 5 years ago

Fixed