search

OasisLMF / ktools

In-memory simulation kernel for loss modelling.
BSD 3-Clause "New" or "Revised" License
28 stars 19 forks source link

Bring split TIV calculation in line with gulpy #338

Closed hchagani-oasislmf closed 1 year ago

hchagani-oasislmf commented 1 year ago

Bring split TIV calculation in line with gulpy

With gulcalc allocation rule greater than 0, if the sum of losses per sample exceed the TIV, the TIV is split in proportion to the losses. There is no need to do this for the standard deviation (sidx = -2) nor for the chance of loss (sidx = -4). Therefore, the calculation on these fields has been dropped to bring it in line with that which is currently conducted in gulpy.

johcarter commented 1 year ago

on this branch running ktest and looking at testout @hchagani-oasislmf I can see sidx -2 losses in gulcalci.csv. Ktest passes and this file does not seem to have changed in this PR so I don't understand what has changed?

hchagani-oasislmf commented 1 year ago

Thanks @johcarter. I don't think we should a change in gulcalci.csv as only one item is associated with each coverage ID. Have I understood that correctly?