search

OatmealDome / dolphin-ios

Dolphin for iOS, reborn
Other
250 stars 27 forks source link

Crash in JITMemoryTracker #33

Closed OatmealDome closed 1 year ago

OatmealDome commented 1 year ago

Crash report from brand:

Thread 17 name:  CPU thread
Thread 17 Crashed:
0   libdolphin.dylib                       0x105153e54 Common::JITMemoryTracker::JITRegionWriteEnableExecuteDisable(void*) + 16
1   libdolphin.dylib                       0x105153e50 Common::JITMemoryTracker::JITRegionWriteEnableExecuteDisable(void*) + 12

Possibly threading issue (simultaneous access)? Probably should include locks in every call that modifies the map.

OatmealDome commented 1 year ago

Mitigations added for simultaneous access. Let's see if this appears again in the next beta.

Simonx22 commented 1 year ago

Does this issue still occur?

OatmealDome commented 1 year ago

Going to assume this issue is fixed. If I see it reappear, I'll reopen this issue.