search

OatmealDome / dolphin-ios

Dolphin for iOS, reborn
Other
250 stars 27 forks source link

Dolphin iOS: Add Simple Skylander Portal #68

Open deReeperJosh opened 1 year ago

deReeperJosh commented 1 year ago

With the Skylander Portal now in mainline Dolphin, I have seen a few requests come through (like here https://github.com/OatmealDome/dolphin-ios/issues/60) to bring the functionality to Dolphin iOS, so this PR aims to implement that here. The only relevant commit is the most recent one, the rest have been cherry-picked from the main Dolphin Repo.

As a start, I haven't added the create Skylander Functionality, so users can either just use their existing Dumps or use ones they have created on Dolphin for Desktop.

I have tried to make it as simple as possible, and not clog up the UI - so Users can select to Load, Clear or Clear All. Load will load in to the next available slot (determined in the C++ code), Clear will clear the Skylander from the most recently used Slot, and Clear all will reset the portal.

If it would be better to create a Dialog Window with the full create, load and clear functionality, I can try to implement that further down the line, but for now the UIAlert is limited with what can and can't be done. Screenshots below:

Position in the Left Menu IMG_0524

The Alert Dialog IMG_0525

In Game IMG_0526

Spidy123222 commented 1 year ago

I do know that there is other games that also uses nfc characters like Disney Infinity. Do you think it could be used for such game or others? If so wouldn’t the name be better to describe it as load figure dump (Skylanders Portal), figuring manager (skylander manager).

deReeperJosh commented 1 year ago

@Spidy123222 yeah I have got another PR open (https://github.com/dolphin-emu/dolphin/pull/11546) to emulate the Infinity Base - but the structure for dumps for Infinity is much different and a lot more complex, would want a separate UIAction for that with different names

OatmealDome commented 1 year ago

Since there's a bunch of commits here that have been merged upstream already, would it be OK if I merged upstream on master and have you rebase this PR?

deReeperJosh commented 1 year ago

@OatmealDome yeah of course - I'm happy with that

deReeperJosh commented 1 year ago

Let me just take a bit of time to get this to only the one commit of things that are relevant - I might have missed a commit or 2 when cherry-picking

deReeperJosh commented 1 year ago

This is where I want it now - not sure about the XCode auto generated changes, but can revert those where needed