search

Obbut / iCloud-Control

User-controlled selective sync for iCloud Drive
830 stars 60 forks source link

Issue with button icon color on Mojave #8

Closed grimnico closed 5 years ago

grimnico commented 6 years ago

The control button in the finder does not support the dark mojave mode. The color of the icon should change to white.

eplusg-zz commented 5 years ago

Having the same issue 😢 Would be really nice with white icon so it fits dark mode.

Gevoraway commented 5 years ago

Agree. The icon needs to be updated to match Mojave dark mode

zzxjohn commented 5 years ago

+1

joakimhew commented 5 years ago

@NicolasGrimonpont @Endilus @Gevoraway @zzxjohn

While we're waiting for Obbut to support this I've made a release that fixes this in the meantime 😀 Just download and replace your current iCloud Control app with the following:

1.1.0-dark-mode-support

Don't forget to relaunch finder when you switch between light mode and dark mode. Cheers!

toadle commented 5 years ago

@NicolasGrimonpont @Endilus @Gevoraway @zzxjohn @joakimhew

Wow this app is a live-safer. Also having dark-mode support is great. Would you guys be interested in to also add localization?

I could provide German.

joakimhew commented 5 years ago

@toadle I could possibly help with localization. Unfortunately I'm not the author of this repository and I'm not sure if the original maintainer is interested in help with it so for now it'll have to be my fork.

@Obbut Would you be interested in adding me as a maintainer? I'd be happy to help keep it updated!

Obbut commented 5 years ago

Sorry, I've been quite busy so that's why I didn't reply earlier.

@joakimhew Thanks for your PR! I've merged it for now. I'll make a new release.

If you have ideas about improving this app and want to help, like adding more features like localization, I would be happy to discuss the options. Maybe the easiest way for that is to get in touch using a chat service. I'm reachable on the OpenKitten Slack (that's the Slack for some other Swift projects that I maintain), or on Telegram as @Obbut

toadle commented 5 years ago

@joakimhew BTW: There can be a problem after switching into Dark Mode that the icon stays in the color of the mode before. I noticed this while using https://nightowl.kramser.xyz/

joakimhew commented 5 years ago

@toadle Yup, I'm not sure why this happens as other icons in the finder are updated. But a simple relaunch of the finder should fix it.

⎇ + right click on the finder, and then click relaunch 👍

@Obbut I'll join your slack and we can have chat about it!