Adding fault parameters to Service interfaces operations

[lbroudoux]

Hello,

as a consequence of http://www.obeonetwork.com/group/informationsystem/forum/topics/soa-ecore-model-completion-with-fault discussion ; here's 2 commits adding fault parameters to service operations and the corresponding view and tool within service contract designer view.

I've done some tests with new model and everything works fine on Obeo Designer 6.0.

Regards,

[sthibaudeau]

Hello Laurent,

I've started reviewing your pull request. Unfortunately it seems that you've used the "soa.genmodel" model to regenrate the whole EMF code. You should have used "soa_cdonative.genmodel" instead because this metamodel has to be a CDO native one. I know it's a pity that the old "soa.genmodel" is still there and we should remove it once we're sure we won't lost anything (because of wrong links between models).

Could you please regenerate the code using the right genmodel ? If you want to make sure you've used the right one you can look at the Impl classes. When in cdo-native mode, there is no generated instance attributes anymore.

Regards, Stéphane.

[lbroudoux]

Hello Stephane,

I've regenerated with evening using the CDO native genmodel. Instance attributes in implementation model classes are no longer there. I've tried regenerated edit code too but the CDO native genmodel does not to bring any modification to them (so they are not present in the committed files).

New additions work as well onto my OD test instance.

Regards,

[lbroudoux]

Hello Stephane,

did you have any chance reviewing this pull request in the forthcoming days ? I'd like to upgrade my generators with fault related stuffs and it will be great having this feature present in your "official" repo trunk.

Best regards,

[sthibaudeau]

Hello Laurent,

We're getting very close to the point where I could merge your pull request. Here are the last points I'd like to fix before merging : 1) in the "org.obeonetwork.dsl.is.design" plug-in could you please remove the fixed version number on the dependencies towards Cinematic and SOA ? (in MANIFEST.MF) 2) in the same plugin, in the odesign file I've seen that the Binding Editor representation (and a tool to create such a diagram) have disappeared. It's a special representation built upon a custom representation type (using Nebula tree Mapper for information). Could you please reinsert this representation and tool ? If not, just tell me and I'll reinsert it after merging your work. 3) in the "org.obeonetwork.dsl.soa.edit" plug-in could you please remove the "icons/full/.notgenerated" file ? 4) could you please regenerate the "org.obeonetwork.dsl.soa.edit" using the CDO native genmodel ? The only difference is that the generated editor does not have multiple pages. You then should see no difference in this plug-in when comparing with master.

Best regards, Stéphane

[sthibaudeau]

I confirm that you can delete the ".notgenerated" file.

Thanks, Stéphane.

[lbroudoux]

Hello Stephane,

I've made a new commit that - I hope - will fix the last issues.

Regards, Le 12 mars 2013 12:10, "Stéphane Thibaudeau" notifications@github.com a écrit :

I confirm that you can delete the ".notgenerated" file.

Thanks, Stéphane.

— Reply to this email directly or view it on GitHubhttps://github.com/ObeoNetwork/InformationSystem/pull/6#issuecomment-14769458 .

[sthibaudeau]

Laurent,

Thanks for your contribution.