search

ObeoNetwork / POOSL

Eclipse Public License 2.0
1 stars 0 forks source link

Improve Diagram Layout #83

Closed mypsycho closed 3 years ago

mypsycho commented 3 years ago

image Using: ELK Layered aglo

  1. Improve location of port: should be inside the port
  2. 'ELK.edge routing=ORTHOGONAL' should produce 'Routing style = Rectilinear'
  3. Container size: try to deal with truncated names

image Using: ELK tree aglo

  1. Edge ends are improper when decorated.
  2. Label is ignored leading to unexpected placement.
  3. Container size: label size is ignored.
mypsycho commented 3 years ago

We could also force such properties in product:

/instance/org.eclipse.sirius.diagram.ui/GridRuler.gridSpacing=20.0
/instance/org.eclipse.sirius.diagram.ui/GridRuler.rulerUnits=2
/instance/org.eclipse.sirius.diagram.ui/GridRuler.snapToGeometry=true
/instance/org.eclipse.sirius.diagram.ui/GridRuler.snapToGrid=true

By limiting the number of possible points, alignment is made easier, space between elements is regular.

mypsycho commented 3 years ago

About composition layout previous layout. image

We keep ELK as in complex diagram we know layout is better.

Port label can be improved by customisation but a ELK ticket is opened for it: https://bugs.eclipse.org/bugs/show_bug.cgi?id=568981

mypsycho commented 3 years ago

About class layout Previous layout: default GMF image

We keep default layout to avoid improper display.