search

Oberhauser-Dev / gb-fullcalendar

GB FullCalendar is a branch of the popular WP FullCalendar plugin written as a Gutenberg block.
GNU General Public License v3.0
6 stars 3 forks source link

Use excerpt for tooltip instead of whole content #16

Closed davidkopp closed 4 years ago

davidkopp commented 4 years ago

Currently the whole description of an event is used for the tooltip. Usually that's too much content. The tooltip should only show the excerpt of the event.

Gustl22 commented 4 years ago

Hey, thanks a lot for your contribution! would you agree, showing the content as fallback, if the excerpt is empty? People migrating from WP-FullCalendar might expect that behavior (I took their implementation).

davidkopp commented 4 years ago

Yes, in that case I agree that showing the content as a fallback is a good approach. I have adapted the implementation accordingly.

Gustl22 commented 4 years ago

Thank you very much for your Merge-Request! Hope I don't bother you, if I use the ternary operator in order to lessen code.