search

Oberhauser-Dev / wrestling_scoreboard

Wrestling software for managing team matches and competitions.
https://oberhauser-dev.github.io/wrestling_scoreboard/
MIT License
3 stars 0 forks source link

feat: Lazy load fonts #57

Closed Zomtir closed 3 months ago

Zomtir commented 3 months ago

Could be split up into dedicated pull request if necessary, but I'd prefer to rebase this branch if changes occur.

4c7ed02

Parallelizes LoadingBuilders in Settings for the first block. Could/should also be done further down, but this is a first proof of concept.

65871dc

Extracts the FontRadioDialog Widget

bedd444

Modifies the FontDialog to have a state and lazy loads the fonts. It loads one font each 300 ms currently which is a fine speed, but there's way too many fonts available to ever reach reasonable performance. Either there needs to be a subset for selection or buffering needs to start upon launching the app (which is not reasonable imo).

Zomtir commented 3 months ago

Also 4c7ed02 breaks closing/cancelling/accepting the RadioDialog and returns to the main screen. I couldn't figure out how the Navigator pops the RadioDialog.

Gustl22 commented 3 months ago

Pushed some improvements on your branch. Due to list optimizations, can show the fonts now directly. Any further proposals?

Also https://github.com/Oberhauser-Dev/wrestling_scoreboard/commit/4c7ed02d37e3475819457968773ead4770b80400 breaks closing/cancelling/accepting the RadioDialog and returns to the main screen. I couldn't figure out how the Navigator pops the RadioDialog.

Fixed on main now.

Zomtir commented 3 months ago

Pushed some improvements on your branch.

Should I rebase / squash / amend some commits?