Oberon00 / luabind

Luabind is a library that helps you create bindings between C++ and Lua.
http://oberon00.github.io/luabind/
Other
46 stars 13 forks source link

Boost version requirement #7

Closed rpavlik closed 11 years ago

rpavlik commented 11 years ago

Thanks for continuing work on this! I noticed that your CMake script demands Boost 1.51.0 or newer. Unless you've specifically used a feature of newer boost, that can probably be dialed back to 1.40 at least, since that's what I was developing my fork using.

rpavlik commented 11 years ago

OK, so it looks like BOOST_NOEXCEPT_IF isn't in 1.46.1, which is the version in the latest Ubuntu LTS release (Precise) and what I'm using now. Any way we can just put this in a little workaround header?

Oberon00 commented 11 years ago

I noticed that your CMake script demands Boost 1.51.0 or newer.

Actually that was just the Boost version I was using at that time. Probably I should really try to figure out what is required or just leave out the version requirement.

OK, so it looks like BOOST_NOEXCEPT_IF isn't in 1.46.1. Any way we can just put this in a little workaround header?

Yes, I will look into that. If nothing else, I could at least define it to nothing (Luabind would have to be compiled with the CMake variable LUABIND_NO_CXX11 set to ON then).

EDIT: Looking at http://www.boost.org/doc/libs/1_54_0/libs/config/doc/html/boost_config/boost_macro_reference.html#boost_config.boost_macro_reference.boost_deprecated_macros, this is not the only problem.

rpavlik commented 11 years ago

It would be useful if they had mentioned when the replacements had been added. Some days I think I should make a repo with the contents of each boost release tarball as a subsequent commit, to make these investigations easier.

Oberon00 commented 11 years ago

I seems that the replacements have been added when the macros were deprecated (i.e. 1.50 and 1.51), but I will just check both.

rpavlik commented 11 years ago

Well, in at least one case I got my merged branch to build using boost 1.46.1 :)

Oberon00 commented 11 years ago

I'll fix this (see my comment here: https://github.com/Oberon00/luabind/issues/11#issuecomment-22807667).