search

ObieSource / obiesource.github.io

The ObieSource Website. Project Leader: Ajai Nelson
https://obiesource.github.io/
2 stars 22 forks source link

Added members directory and page for displaying information about clu… #2

Closed FiskFan1999 closed 2 years ago

FiskFan1999 commented 2 years ago

…b members

I'm pretty sure I ironed out those html injection issues that Ajai was talking about. Let me know if you think this needs anything else. I can walk you through the steps needed to add yourself but basically you cp members/rehwinkel.json members/yourname.json and then add a line in /memberslist.json for yourself.

wknowleskellett commented 2 years ago

How can we preview this as a webpage?

AjaiKN commented 2 years ago

Run make host. (I was reviewing this just as you commented.)

iosenberg commented 2 years ago

@FiskFan1999 These changes look great! I think this is a great direction for this page to go, and would provide a good opportunity for new members/beginners to learn how to do pull requests. Down the line, I'll make a contributor's guide to help out on that front. Since we don't have an official way to accept pull requests as a club, I'm considering two approved reviews a club acceptance. I will definitely approve, after the ul issue is fixed, so we can keep the site HTML-legal.

FiskFan1999 commented 2 years ago

Thank you for all your comments @wknowleskellett @iosenberg @Aurelius333 , I actually fixed illegal blocks inside the unordered list block this time.

iosenberg commented 2 years ago

Looks great! I fixed up one more file which was missing a bracket, but other than that this is all legal now, and seems good! I'm cool to approve and merge now.